Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Text color secondary (epub, pdf, zip) are linked to text color #227

Closed
zeoint opened this issue Aug 9, 2023 · 8 comments
Closed

Some Text color secondary (epub, pdf, zip) are linked to text color #227

zeoint opened this issue Aug 9, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@zeoint
Copy link

zeoint commented Aug 9, 2023

Type of installation

Portable (.zip)

Steps to reproduce

  1. Change the secondary text color to another color.
  2. Some button styled epub, zip, pdf that are in location tab, settings menu are not linked to text color secondary, but are linked to font color.

✔️ Expected Behavior

For the epub, zip, pdf that are in location tab, settings tab, to be linked to text color secondary.

❌ Actual Behavior

They are linked to text color.

@zeoint zeoint added the bug Something isn't working label Aug 9, 2023
@mienaiyami
Copy link
Owner

I did that in #217 (comment) because size wasnt the problem.
image
image

As you can see that they are hard to read, even with same size.
If you have any suggestion, then do mention. Otherwise, I think I might revert the changes because its just a "bad theme" thing (even thought I made that theme).

@zeoint
Copy link
Author

zeoint commented Aug 9, 2023

As you can see that they are hard to read, even with same size.
If you have any suggestion, then do mention. Otherwise, I think I might revert the changes because its just a "bad theme" thing (even thought I made that theme).

Can you please rephrase, I did not understand.

@mienaiyami
Copy link
Owner

What I meant to say is, I intentionally made it to use font color in settings because they aren't really small, #217 (comment), they just have a bad match up of color in case of "theme2" and "secondary text color". The contrast ratio is bad and I couldn't think of a better way to fix this.

Before #217 (comment), and even now (outside settings) they use came color as text beside them.
Because they are used in places where both "font color" and "secondary font color" are, I decided not to give it its own variable for color because it can make it stand out a lot in some place.

@zeoint
Copy link
Author

zeoint commented Aug 9, 2023

Oh, Cool.

@mienaiyami
Copy link
Owner

If you have any suggestion, then please mention. Otherwise, I dont think there is a direct fix for it.

@zeoint
Copy link
Author

zeoint commented Aug 10, 2023

Since they are code, its better to add "Code Text Color" in theme maker.
There is already "Code BG Color" and "Code Shadow Color".

But I think its not ideal.
In continue reading tab, it feels out of place for every theme since it takes the same color as text beside them.
They are there to know that an item is an epub / pdf / archive at a glance.
Kindly check the below images.

@zeoint
Copy link
Author

zeoint commented Aug 10, 2023

One can change the secondary text color to improve the readability of the code in continue reading tab.
But it also changes the color of the chapter, so adding code text color would solve it for all needs.

@zeoint
Copy link
Author

zeoint commented Aug 10, 2023

I decided not to give it its own variable for color because it can make it stand out a lot in some place.

But they are there to stand out, to know at a glance the type of item. If it seems out of place, then one can just change them accordingly in theme maker.

mienaiyami added a commit that referenced this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants