-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Text color secondary (epub, pdf, zip) are linked to text color #227
Comments
I did that in #217 (comment) because size wasnt the problem. As you can see that they are hard to read, even with same size. |
Can you please rephrase, I did not understand. |
What I meant to say is, I intentionally made it to use font color in settings because they aren't really small, #217 (comment), they just have a bad match up of color in case of "theme2" and "secondary text color". The contrast ratio is bad and I couldn't think of a better way to fix this. Before #217 (comment), and even now (outside settings) they use came color as text beside them. |
Oh, Cool. |
If you have any suggestion, then please mention. Otherwise, I dont think there is a direct fix for it. |
Since they are code, its better to add "Code Text Color" in theme maker. But I think its not ideal. |
One can change the secondary text color to improve the readability of the code in continue reading tab. |
But they are there to stand out, to know at a glance the type of item. If it seems out of place, then one can just change them accordingly in theme maker. |
Type of installation
Portable (.zip)
Steps to reproduce
✔️ Expected Behavior
For the epub, zip, pdf that are in location tab, settings tab, to be linked to text color secondary.
❌ Actual Behavior
They are linked to text color.
The text was updated successfully, but these errors were encountered: