-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epub navigation #202
Comments
I was already planning to make option to not temp files after app close so they can be opened again without big loading time. This does sound like a better option in term of overall performance but at same time its a lot more complex. |
Added in 2.15.1 as test. |
Yes, please. Even when a manga has 1000's of chapters, there is no effect on performance, because they are not in archive format. |
It will though, since those new created files are kind of temp files. Also, it will be taking more than double the storage.
Thats true. |
How? There will only be the chapter .xhtml files.
Any unzipped archive would go back to its original size. |
Or does it not work this way. |
Maybe I didnt get what you mean.
Usually theres one or two stylesheets and they apply to all chapters. But they do not contain just line, paragraph space, etc., there are many other styles.
What does that mean? |
For example, yomikiru v2.15.3 has a download size of 88 mb, when unzipped it becomes 200mb which is its original size.
It was a big misunderstanding. I should have explained it more clearly. |
The process I thought of,
|
|
|
What you said is true for official epub's. They have no performance issues. I should have said this sooner. I am talking about the epub's that are downloaded manually from a website like I mentioned previously using webtoepub.
|
It turned out to be harder than expected. Everything is there to make it work but it require me to make a separate file as manga and epub have their own. Which I dont want to because then I will have same code everywhere. |
Yes, Im not talking about that. that part is actually very easy. Btw, if you havent noted yet, the lag and stutter is because of the item count in side list (its present in manga side list as well). |
Do you mean the lag that occurs when resizing the side list?
So temp files are needed even for the extracted .xhtml files. |
Or, are you talking about the reader lag? Yes, I have noticed it, compared to the version v2.12.3, the epub reader is laggy while going to another chapter in the present version. While in v2.12.3, the chapter transition was smooth and lag free. |
No, I mean that lag will be there as long as there is high chapter count in sidelist, its same for manga's side list. |
Thats because of #177 (comment) , it wasnt updating because whole sidelist was not rendered as at all in zen mode. But now that side list is rendered and just hidden. So sise-list is re-rendered every time chapter changes and because chapter count is too high, it cause big lags. It is also the reason for scrolling not being smooth. #177 (comment), though I did say that, I just made side-list render even in zenmode. I even tested it on epub with 500chapters but didnt see any issue at that time, but maybe I need to use this approach instead. |
So you are saying you can make the reader smooth while scrolling, chapter transition, like it was before, right? |
Yes, but it will result in the big lag when exiting zen mode. So, I think scrolling and chapter transition performance is preferred over this? |
Yes. |
If removing #177 would improve the overall performance of the epub reader, then please do. |
Below is a video comparsion of chapter transition performance between v2.12.3 and v2.16.1. |
Thats probably because of #190. I will need to look for a better way to do this. Though, Im still planning to implement this to support files with text. |
Cool. If needed for performance, please remove it. |
As I said above.
Even that is a lot for an epub. test.mp4As you can see here, the lag in changing chapter is side list, and its better in zen mode. |
Indeed it is.
If you found a way in future, please implement it.
Cool. Yomikiru is already the best all in one reader. |
Would this be in the upcoming update? |
Very unlikely, as i said before, it will require me to make a new type of reader just like manga and epub, So, Im trying to clean old code that caused big problems when making epub reader. |
Cool. |
As I had expected, the scrolling is very smooth even when there are 1000's of chapters. Thank you for implementing this. |
I will be closing this since it was completed. |
Description of the new feature / enhancement
So I have an idea to solve this. I don't know if it is possible to do this.
Drawback
Scenario when this would be used?
Supporting information
The text was updated successfully, but these errors were encountered: