Move compress=false out of packDataDomainNames into caller (#849)

This makes packDataDomainNames more consistent with PackDomainName where it will only be called with compress = true for `dns:"cdomain-name"`.
miekg · Nov 30, 2018 · 6ade5b5 · 6ade5b5
1 parent 778aa4f
commit 6ade5b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/msg_generate.go b/msg_generate.go
diff --git a/msg_helpers.go b/msg_helpers.go
@@ -624,7 +624,7 @@ func unpackDataDomainNames(msg []byte, off, end int) ([]string, int, error) {
 func packDataDomainNames(names []string, msg []byte, off int, compression map[string]int, compress bool) (int, error) {
 	var err error
 	for j := 0; j < len(names); j++ {
-		off, err = PackDomainName(names[j], msg, off, compression, false && compress)
+		off, err = PackDomainName(names[j], msg, off, compression, compress)
 		if err != nil {
 			return len(msg), err
 		}

diff --git a/zmsg.go b/zmsg.go