Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty framework ready #882

Merged
merged 2 commits into from
Mar 3, 2021
Merged

fix: empty framework ready #882

merged 2 commits into from
Mar 3, 2021

Conversation

czy88840616
Copy link
Member

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Mar 3, 2021

@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #882 (86b140a) into 2.x (ee992e8) will decrease coverage by 0.12%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #882      +/-   ##
==========================================
- Coverage   86.60%   86.48%   -0.13%     
==========================================
  Files         183      183              
  Lines        7415     7427      +12     
  Branches     1454     1454              
==========================================
+ Hits         6422     6423       +1     
- Misses        952      963      +11     
  Partials       41       41              
Impacted Files Coverage Δ
packages/core/src/util/emptyFramework.ts 50.00% <75.00%> (-41.67%) ⬇️
packages/core/src/util/webRouterCollector.ts 95.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee992e8...86b140a. Read the comment docs.

@czy88840616 czy88840616 merged commit a2dc36f into 2.x Mar 3, 2021
@czy88840616 czy88840616 deleted the fix_empty_framework_ready branch March 3, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants