fix: inject definition bug (#878)

midwayjs · Mar 1, 2021 · e11a057 · e11a057
1 parent b4b84ef
commit e11a057
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/decorator/src/common/decoratorManager.ts b/packages/decorator/src/common/decoratorManager.ts
@@ -959,7 +959,11 @@ export function savePropertyInject(opts: InjectOptions) {
   let identifier = opts.identifier;
   if (!identifier) {
     const type = getPropertyType(opts.target, opts.targetKey);
-    if (!type.isBaseType && isClass(type.originDesign)) {
+    if (
+      !type.isBaseType &&
+      isClass(type.originDesign) &&
+      isProvide(type.originDesign)
+    ) {
       identifier = getProviderId(type.originDesign);
     }
     if (!identifier) {

diff --git a/packages/decorator/test/annotation/inject.test.ts b/packages/decorator/test/annotation/inject.test.ts
@@ -67,7 +67,7 @@ describe('/test/annotation/inject.test.ts', () => {
       ff: [
         {
           'key': 'inject',
-          'value': 'injectChild2'
+          'value': 'ff'
         }
       ]
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,7 +67,7 @@ describe('/test/annotation/inject.test.ts', () => { @@
           ff: [
             {
               'key': 'inject',
-              'value': 'injectChild2'
+              'value': 'ff'
             }
           ]
         });
@@ Expand Down @@