fix: add target parameter (#1139)

midwayjs · Jul 6, 2021 · 5be4757 · 5be4757
1 parent 9e0e7e5
commit 5be4757
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages-serverless/serverless-http-parser/src/http/req.ts b/packages-serverless/serverless-http-parser/src/http/req.ts
@@ -10,8 +10,8 @@ const EVENT_PARSED = Symbol.for('ctx#event_parsed');
 const BODY = Symbol.for('ctx#body');
 
 export class HTTPRequest {
-  private originContext;
-  private originEvent;
+  private readonly originContext;
+  private readonly originEvent;
   public bodyParsed = false;
 
   constructor(event, context) {
@@ -52,8 +52,8 @@ export class HTTPRequest {
 
   get url() {
     if (!this[EVENT].url) {
-      const querystirng = (qs as any).stringify(this.query || {});
-      this[EVENT].url = this.path + (querystirng ? '?' + querystirng : '');
+      const querystring = (qs as any).stringify(this.query || {});
+      this[EVENT].url = this.path + (querystring ? '?' + querystring : '');
     }
     return this[EVENT].url;
   }

diff --git a/packages/core/src/service/configService.ts b/packages/core/src/service/configService.ts
@@ -84,7 +84,7 @@ export class MidwayConfigService implements IConfigService {
     // merge set
     const target = {};
     for (const filename of [...defaultSet, ...currentEnvSet]) {
-      const config = await this.loadConfig(filename);
+      const config = await this.loadConfig(filename, target);
 
       if (!config) {
         continue;
@@ -113,7 +113,7 @@ export class MidwayConfigService implements IConfigService {
     return this.configuration;
   }
 
-  async loadConfig(configFilename): Promise<Record<string, unknown>> {
+  async loadConfig(configFilename, target?): Promise<Record<string, unknown>> {
     debug('load config %s.', configFilename);
     let exports = require(configFilename);
     if (exports && exports['default'] && Object.keys(exports).length === 1) {
@@ -132,6 +132,7 @@ export class MidwayConfigService implements IConfigService {
           HOME: informationService.getHome(),
           root: informationService.getRoot(),
         },
+        target,
       ]);
     }
     return result;