fix: transform type after validate (#659)

midwayjs · Oct 4, 2020 · 2b30ba7 · 2b30ba7
1 parent daa28ff
commit 2b30ba7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/packages/decorator/jest.config.js b/packages/decorator/jest.config.js
@@ -0,0 +1,7 @@
+const path = require('path');
+
+module.exports = {
+  preset: 'ts-jest',
+  testPathIgnorePatterns: ['<rootDir>/test/fixtures'],
+  coveragePathIgnorePatterns: ['<rootDir>/test/'],
+};
diff --git a/packages/decorator/src/annotation/validate.ts b/packages/decorator/src/annotation/validate.ts
@@ -20,6 +20,8 @@ export function Validate(isTransform = true) {
           const result = schema.validate(args[i]);
           if (result.error) {
             throw result.error;
+          } else {
+            args[i] = result.value;
           }
           // passed
           if (isTransform) {

diff --git a/packages/decorator/test/annotation/check.test.ts b/packages/decorator/test/annotation/check.test.ts
@@ -167,4 +167,23 @@ describe('/test/annotation/check.test.ts', () => {
       new Hello().school(1, user);
     }).toThrow(Error);
   });
+
+  it('should transform string to number', function () {
+    class UserNewDTO {
+      @Rule(RuleType.number().required())
+      id: number;
+    }
+
+    class Hello {
+      @Validate()
+      school(user: UserNewDTO) {
+        return user;
+      }
+    }
+
+    const data = new Hello().school({
+      id: '555'
+    } as any)
+    expect(typeof data.id).toEqual('number');
+  });
 });