Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop odataQueryHandler #408

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Drop odataQueryHandler #408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55239ff
Drop odataQueryHandler
andrueastman Apr 12, 2022
0756b57
PR review comments
andrueastman Apr 12, 2022
6fe52b1
- updates kiota packages references
baywet Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Graph.Core/Requests/GraphClientFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public static IList<DelegatingHandler> CreateDefaultHandlers(GraphClientOptions
{
return new List<DelegatingHandler> {
new GraphTelemetryHandler(graphClientOptions),
new OdataQueryHandler(),
new ParametersNameDecodingHandler(),
new CompressionHandler(),
new RetryHandler(),
new RedirectHandler()
Expand Down
59 changes: 0 additions & 59 deletions src/Microsoft.Graph.Core/Requests/Middleware/OdataQueryHandler.cs
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions src/Microsoft.Graph.Core/Requests/Middleware/Options/ODataQueryHandlerOption.cs
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/GraphClientFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void Should_CreatePipeline_Without_CompressionHandler()
public void Should_CreatePipeline_Without_HttpMessageHandlerInput()
{
using GraphTelemetryHandler telemetryHandler = (GraphTelemetryHandler)GraphClientFactory.CreatePipeline(handlers);
using OdataQueryHandler odataQueryHandler = (OdataQueryHandler)telemetryHandler.InnerHandler;
using ParametersNameDecodingHandler odataQueryHandler = (ParametersNameDecodingHandler)telemetryHandler.InnerHandler;
using CompressionHandler compressionHandler = (CompressionHandler)odataQueryHandler.InnerHandler;
using RetryHandler retryHandler = (RetryHandler)compressionHandler.InnerHandler;
using RedirectHandler redirectHandler = (RedirectHandler)retryHandler.InnerHandler;
Expand All @@ -82,7 +82,7 @@ public void Should_CreatePipeline_Without_HttpMessageHandlerInput()
Assert.NotNull(redirectHandler);
Assert.NotNull(innerMost);
Assert.IsType<GraphTelemetryHandler>(telemetryHandler);
Assert.IsType<OdataQueryHandler>(odataQueryHandler);
Assert.IsType<ParametersNameDecodingHandler>(odataQueryHandler);
Assert.IsType<CompressionHandler>(compressionHandler);
Assert.IsType<RetryHandler>(retryHandler);
Assert.IsType<RedirectHandler>(redirectHandler);
Expand All @@ -94,7 +94,7 @@ public void Should_CreatePipeline_Without_HttpMessageHandlerInput()
public void CreatePipelineWithHttpMessageHandlerInput()
{
using GraphTelemetryHandler telemetryHandler = (GraphTelemetryHandler)GraphClientFactory.CreatePipeline(handlers, new MockRedirectHandler());
using OdataQueryHandler odataQueryHandler = (OdataQueryHandler)telemetryHandler.InnerHandler;
using ParametersNameDecodingHandler odataQueryHandler = (ParametersNameDecodingHandler)telemetryHandler.InnerHandler;
using CompressionHandler compressionHandler = (CompressionHandler)odataQueryHandler.InnerHandler;
using RetryHandler retryHandler = (RetryHandler)compressionHandler.InnerHandler;
using RedirectHandler redirectHandler = (RedirectHandler)retryHandler.InnerHandler;
Expand All @@ -107,7 +107,7 @@ public void CreatePipelineWithHttpMessageHandlerInput()
Assert.NotNull(redirectHandler);
Assert.NotNull(innerMost);
Assert.IsType<GraphTelemetryHandler>(telemetryHandler);
Assert.IsType<OdataQueryHandler>(odataQueryHandler);
Assert.IsType<ParametersNameDecodingHandler>(odataQueryHandler);
Assert.IsType<CompressionHandler>(compressionHandler);
Assert.IsType<RetryHandler>(retryHandler);
Assert.IsType<RedirectHandler>(redirectHandler);
Expand Down
106 changes: 0 additions & 106 deletions tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/Middleware/OdataQueryHandlerTests.cs
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/Middleware/TelemetryHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,17 @@ public async Task TelemetryHandlerShouldSetTelemetryHeaderWithCustomConfiguratio
Assert.Contains($" runtimeEnvironment={RuntimeInformation.FrameworkDescription};", telemetryHeaderString);
}
}

internal class FakeSuccessHandler : DelegatingHandler
{
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
var response = new HttpResponseMessage
{
StatusCode = System.Net.HttpStatusCode.OK,
RequestMessage = request
};
return Task.FromResult(response);
}
}
}