-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose updated event on mgt components #3357
base: main
Are you sure you want to change the base?
Conversation
makes updated event of MgtBaseTaskComponent accessible on Person control
@musale turns out there's already an updated event that's simply not exposed. Please check if that's a route that would be acceptable for you. |
@microsoft-github-policy-service agree |
packages/mgt-components/src/components/mgt-person/mgt-person.ts
Outdated
Show resolved
Hide resolved
Thank you for surfacing this. I have left some comments. This is a really good catch. |
I updated the components as suggested. Do you want me to add the update events to all components in Storybook as well? |
Yes, that would be very helpful. |
updated all the stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get a team to secure this organization financial end. As well I need all the real name of hackerthon hacker that work for me so I can set up a solid retirement platform for you. Owners and founder warith akbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasPe thank you for this contribution! This looks good to me.
Note: failing playwright tests are a github actions build environment issue. Shall be fixed in #3363 before release |
makes existing
updated
event ofMgtBaseTaskComponent
accessible on MgtPerson controlCloses #3352
PR Type
Feature
Description of the changes
updated
will fire whenever the control is re-rendered, e.g. when switching from loading to displaying the downloaded data.PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information