Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move electron to peer dependency #3046

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2904

PR Type

  • Feature

Description of the changes

Makes the electron dependency a peer dependency to allow for developers to choose the version that they use.
Expands the context bridge to ensure proper support for scope aware requests

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

I'll push a sample app for the electron provider that uses the npm published version of this branch tomorrow to allow for testing.

@gavinbarron gavinbarron requested a review from a team as a code owner February 14, 2024 01:41
musale
musale previously approved these changes Feb 14, 2024
Mnickii
Mnickii previously approved these changes Feb 14, 2024
@gavinbarron gavinbarron dismissed stale reviews from Mnickii and musale via 9888a35 February 14, 2024 15:16
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 84% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 71% 0
mgt-components.src.components.mgt-person-card 67% 48% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 77% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14190 / 21454) 66% (451 / 680) 0

@gavinbarron
Copy link
Member Author

@musale / @Mnickii I've raised a PR on the sample repo that uses this PR as its dependency version for the moment

pnp/mgt-samples#16

@gavinbarron gavinbarron enabled auto-merge (squash) February 14, 2024 20:31
@gavinbarron
Copy link
Member Author

@musale or @Mnickii could you please re-review this?

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make the electron package a peer dependency in mgt-electron-provider
3 participants