-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply keyboard focus when removing selected person or adding person from suggestion list on people-picker #3011
Conversation
📖 The updated storybook is available here |
1 similar comment
📖 The updated storybook is available here |
📖 The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mnickii I'm facing an issue with the single select mode. When I add a person, the cursor is blinking despite showing that "max contacts added". Also, I'm able to type in the input. This should be disabled, and the cursor should not be blinking in single select mode.
📖 The updated storybook is available here |
📖 The updated storybook is available here |
@vagpt this is ready for review |
📖 The updated storybook is available here |
packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
Outdated
Show resolved
Hide resolved
📖 The updated storybook is available here |
📖 The updated storybook is available here |
@Raisul123 I believe this change resolves the associated issue |
packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
Show resolved
Hide resolved
|
📖 The updated storybook is available here |
Closes #2342
PR Type
Bugfix
Description of the changes
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information