Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the check for an editor before setting the files object. #3004

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: remove the check for an editor before setting the files object. #3004

merged 1 commit into from
Jan 31, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jan 31, 2024

Closes #3003

PR Type

  • Bugfix

Description of the changes

remove the check for an editor before setting the files object.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the v4.0.0 milestone Jan 31, 2024
@musale musale requested a review from a team as a code owner January 31, 2024 12:00
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

sebastienlevert
sebastienlevert approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this works great!

@gavinbarron gavinbarron merged commit daf06bc into main Jan 31, 2024
11 checks passed
@gavinbarron gavinbarron deleted the fix/render-stories-on-docs branch January 31, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@gavinbarron gavinbarron gavinbarron approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] Storybook Docs view not rendering content for any docs page
3 participants
@musale @gavinbarron @sebastienlevert