Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct details alignment in person details when using person-card #2995

Closed
wants to merge 2 commits into from

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jan 30, 2024

Closes #2976

PR Type

Bugfix

Description of the changes

Correct details alignment on person when using person-card property

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner January 30, 2024 14:30
Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

@sebastienlevert
Copy link
Contributor

This was fixed earlier to have different sizes when using the mgt-person component, right?

image

What is the fix here?

@gavinbarron
Copy link
Member

This was fixed earlier to have different sizes when using the mgt-person component, right?

image

What is the fix here?

I'm not understanding your question here. What do you see as being incorrect here?

@gavinbarron
Copy link
Member

This was fixed in #2900

You can see the fix here: https://mgt.dev/next/?path=/story/components-mgt-person-html--person
Specific line that fixes the issue: 65ca8e2#diff-d095e23dbfe5044a36c8cd9c6b10da28c5d6abe5ccd2f146d34f4464428e48ecR230

Given this I'm going to close this PR and the related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] - Alignment of details lines in Person component is no longer centered when using a large profile photo
3 participants