Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set consistent spacing between mentioned people names #2970

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jan 25, 2024

Closes #2883

PR Type

  • Bugfix

Description of the changes

Sets sufficient and consistent spacing on mentioned names.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the Chat - GA milestone Jan 25, 2024
@musale musale requested a review from a team as a code owner January 25, 2024 10:14
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-chat.src.statefulClient 100% 100% 0
mgt-chat.src.utils 100% 86% 0
mgt-components.dist.es6.components.mgt-agenda.src.components.mgt-agenda 12% 100% 0
mgt-components.dist.es6.components.mgt-contact.src.components.mgt-contact 62% 100% 0
mgt-components.dist.es6.components.mgt-file-list.mgt-file-upload.src.components.mgt-file-list.mgt-file-upload 43% 100% 0
mgt-components.dist.es6.components.mgt-file-list.src.components.mgt-file-list 51% 100% 0
mgt-components.dist.es6.components.mgt-file.src.components.mgt-file 46% 100% 0
mgt-components.dist.es6.components.mgt-get.src.components.mgt-get 20% 100% 0
mgt-components.dist.es6.components.mgt-login.src.components.mgt-login 63% 100% 0
mgt-components.dist.es6.components.mgt-messages.src.components.mgt-messages 65% 100% 0
mgt-components.dist.es6.components.mgt-organization.src.components.mgt-organization 46% 100% 0
mgt-components.dist.es6.components.mgt-people-picker.src.components.mgt-people-picker 49% 100% 0
mgt-components.dist.es6.components.mgt-people.src.components.mgt-people 59% 100% 0
mgt-components.dist.es6.components.mgt-person-card.src.components.mgt-person-card 53% 33% 0
mgt-components.dist.es6.components.mgt-person.src.components.mgt-person 48% 100% 0
mgt-components.dist.es6.components.mgt-picker.src.components.mgt-picker 75% 100% 0
mgt-components.dist.es6.components.mgt-profile.src.components.mgt-profile 39% 100% 0
mgt-components.dist.es6.components.mgt-tasks-base.src.components.mgt-tasks-base 76% 100% 0
mgt-components.dist.es6.components.mgt-tasks.src.components.mgt-tasks 54% 100% 0
mgt-components.dist.es6.components.mgt-taxonomy-picker.src.components.mgt-taxonomy-picker 62% 100% 0
mgt-components.dist.es6.components.mgt-teams-channel-picker.src.components.mgt-teams-channel-picker 55% 100% 0
mgt-components.dist.es6.components.mgt-theme-toggle.src.components.mgt-theme-toggle 74% 100% 0
mgt-components.dist.es6.components.mgt-todo.src.components.mgt-todo 80% 100% 0
mgt-components.dist.es6.components.preview.mgt-search-box.src.components.preview.mgt-search-box 74% 100% 0
mgt-components.dist.es6.components.preview.mgt-search-results.src.components.preview.mgt-search-results 51% 100% 0
mgt-components.dist.es6.components.preview.src.components.preview 100% 100% 0
mgt-components.dist.es6.components.src.components 82% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-arrow-options.src.components.sub-components.mgt-arrow-options 70% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-dot-options.src.components.sub-components.mgt-dot-options 28% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-flyout.src.components.sub-components.mgt-flyout 40% 100% 0
mgt-components.dist.es6.components.sub-components.mgt-spinner.src.components.sub-components.mgt-spinner 92% 100% 0
mgt-components.dist.es6.graph.src.graph 36% 100% 0
mgt-components.dist.es6.src 100% 100% 0
mgt-components.dist.es6.styles.src.styles 73% 100% 0
mgt-components.dist.es6.utils.src.utils 46% 100% 0
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 84% 69% 0
mgt-components.src.components.mgt-person-card 66% 47% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 40% 76% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 82% 47% 0
mgt-element.dist.es6.components.src.components 74% 83% 0
mgt-element.dist.es6.mock.src.mock 90% 71% 0
mgt-element.dist.es6.providers.src.providers 86% 77% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 70% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 57% (25863 / 45135) 68% (516 / 755) 0

Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
Copy link

🚀 New react-contoso sample application deployed here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be breaking some experiences. When mentioning Everyone, it does this:

image

And when I'm mentioned, it looks like this:

image

And the full result with other folks:

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jan 25, 2024
Copy link

🚀 New react-contoso sample application deployed here

@musale musale linked an issue Jan 29, 2024 that may be closed by this pull request
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Jan 30, 2024
Copy link

🚀 New react-contoso sample application deployed here

@gavinbarron gavinbarron enabled auto-merge (squash) January 30, 2024 20:30
@gavinbarron gavinbarron merged commit 4a285e1 into next/mgt-chat Jan 30, 2024
8 checks passed
@gavinbarron gavinbarron deleted the fix/space-mentions branch January 30, 2024 20:36
Copy link

🚀 New react-contoso sample application deployed here

plasne added a commit to plasne/microsoft-graph-toolkit that referenced this pull request Jan 31, 2024
fix: set consistent spacing between mentioned people names (microsoftgraph#2970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-chat mentions have insufficent spacing
3 participants