Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove mgt-loader #2963

Merged
merged 7 commits into from
Jan 25, 2024
Merged

feat: remove mgt-loader #2963

merged 7 commits into from
Jan 25, 2024

Conversation

gavinbarron
Copy link
Member

BREAKING CHANGE: mgt-loader.js is removed and there is no support for es5 only browsers direct from CDN. Developers loading mgt from a CDN must use module syntax and explicitly initialize their applications

Closes #1312

PR Type

  • Feature

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron
feat: remove mgt-loader
701821d 
BREAKING CHANGE: mgt-loader.js is removed and there is no support for es5 only browsers direct from CDN. Developers loading mgt from a CDN must use module syntax and explicitly initialize their applications
@gavinbarron gavinbarron requested a review from a team as a code owner January 24, 2024 00:21
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

musale
musale previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Rollup would use an update too. Adding it as a separate issue.

Mnickii
Mnickii previously approved these changes Jan 24, 2024
View reviewed changes
sebastienlevert
sebastienlevert requested changes Jan 24, 2024
View reviewed changes
packages/mgt/rollup.config.js Outdated Show resolved Hide resolved
packages/mgt/package.json Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jan 24, 2024
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Jan 24, 2024
gavinbarron
gavinbarron commented Jan 24, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
@gavinbarron gavinbarron dismissed stale reviews from Mnickii and musale via 481f8e6 January 24, 2024 22:14
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@musale musale mentioned this pull request Jan 25, 2024
Merged
6 tasks
@gavinbarron
Copy link
Member Author

@sebastienlevert your requested changes have been addressed

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0 ✔
mgt-components.src.components.mgt-contact 63% 100% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 78% 65% 0 ✔
mgt-components.src.components.mgt-person-card 55% 57% 0 ➖
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0 ➖
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 78% 12% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 73% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 76% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 66% 69% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 83% 91% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 65% (13914 / 21438) 64% (400 / 627) 0 ➖

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit ea0f71b into main Jan 25, 2024
9 checks passed
@gavinbarron gavinbarron mentioned this pull request Jan 25, 2024
Merged
@gavinbarron gavinbarron mentioned this pull request Feb 5, 2024
Merged
This was referenced Jun 8, 2024
Open
Open
This was referenced Jun 20, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@Mnickii Mnickii Mnickii left review comments

@musale musale musale left review comments

Assignees
No one assigned
Labels
Build: React Contoso Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle should be an es module and not an iife bundle.
4 participants
@gavinbarron @sebastienlevert @musale @Mnickii