-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consolidate person view types #2943
Conversation
removes the PersonViewType enum in favor of the ViewType enum BREAKING CHANGE: PersonViewType has been removed. 'avatar' is no longer a valid value for the 'view' attribute on the 'mgt-person' component
I'd love to see a docs PR for this one. |
Interestingly as I looked at this more closely using This change is essentially eliminate a duplicate type that can cause confusion. |
|
Closes #2941
PR Type
Description of the changes
removes the PersonViewType enum in favor of the ViewType enum
BREAKING CHANGE: PersonViewType has been removed. 'avatar' is no longer a valid value for the 'view' attribute on the 'mgt-person' component
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information