Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate mgt-spfx package #2940

Merged
merged 10 commits into from
Jan 24, 2024
Merged

feat!: deprecate mgt-spfx package #2940

merged 10 commits into from
Jan 24, 2024

Conversation

gavinbarron
Copy link
Member

Closes #2884

PR Type

  • Feature

Description of the changes

removes mgt-spfx code and updates readmes
updates build pipelines

BREAKING CHANGE: mgt-spfx is deprecated, use disambiguation instead

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

removes mgt-spfx code and updates readmes
updates build pipelines

BREAKING CHANGE: mgt-spfx is deprecated, use disambiguation instead
@gavinbarron gavinbarron requested a review from a team as a code owner January 8, 2024 20:28
@gavinbarron gavinbarron changed the title feat: deprecate mgt-spfx package feat!: deprecate mgt-spfx package Jan 8, 2024
packages/mgt-components/README.md Outdated Show resolved Hide resolved
packages/mgt-spfx-utils/README.md Outdated Show resolved Hide resolved
@sebastienlevert
Copy link
Contributor

Also, realizing this will required a backing docs PR to remove any mention of mgt-spfx, the package!

@gavinbarron
Copy link
Member Author

Also, realizing this will required a backing docs PR to remove any mention of mgt-spfx, the package!

Added #2956 to track that work

@gavinbarron
Copy link
Member Author

@sebastienlevert when you get a chance to look at this revision I'd appreciate any feedback you have. Unfortunately some changes around our import + register strategy and disambiguation got co-mingled in here as updating for the removal of mgt-spfx naturally led me to updating that content

gavinbarron and others added 2 commits January 22, 2024 10:28
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 84% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 66% 48% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14153 / 21438) 64% (429 / 667) 0

@gavinbarron gavinbarron merged commit 3da9560 into main Jan 24, 2024
9 checks passed
@gavinbarron gavinbarron deleted the feat/deprecate-mgt-spfx branch January 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Docs] Deprecate mgt-spfx and publish a last package with v3
3 participants