Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add alerts to refresh buttons #2935

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2349

PR Type

  • Bugfix
  • Documentation content changes

Description of the changes

in the mgt-get refresh story buttons now have keypress handlers
adds alerts to make actions apparent

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner January 4, 2024 17:58
adds alerts to make actions apparent

Closes #2349
@gavinbarron gavinbarron force-pushed the docs/fix-get-refresh-buttons branch from f5d752a to 2b4b2e1 Compare January 4, 2024 18:05
@gavinbarron gavinbarron changed the title docs: add keypress handlers to refresh buttons docs: add alerts to refresh buttons Jan 4, 2024
@gavinbarron
Copy link
Member Author

@Raisul123 this resolves the linked issue.

Copy link

github-actions bot commented Jan 4, 2024

📖 The updated storybook is available here

sebastienlevert
sebastienlevert previously approved these changes Jan 4, 2024
@gavinbarron gavinbarron enabled auto-merge (squash) January 5, 2024 16:46
@Raisul123
Copy link
Collaborator

Hi @gavinbarron ,

Issue has been fixed on below test environment.
he updated storybook is available here
https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/23114460/a670505a-00ad-4f1b-acbd-c0188df6f1cf

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 80% 100% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-get 30% 100% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 64% 0
mgt-components.src.components.mgt-person-card 59% 55% 0
mgt-components.src.components.mgt-picker 78% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 77% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 39% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 19% 0
mgt-element.dist.es6.components.src.components 73% 80% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 83% 66% 0
mgt-element.dist.es6.src 90% 100% 0
mgt-element.dist.es6.utils.src.utils 63% 72% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (13847 / 21382) 65% (405 / 625) 0

Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 4dc50cf into main Jan 18, 2024
9 checks passed
@gavinbarron gavinbarron deleted the docs/fix-get-refresh-buttons branch January 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[MGTP-Mgt Get-Refersh]: 'Soft refresh' button is not functional using keyboard and mouse.
3 participants