Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphviz): Add version 2.44.1 #5778

Merged
1 commit merged into from
Jan 4, 2021
Merged

Conversation

GordonSmith
Copy link
Contributor

@GordonSmith GordonSmith commented Dec 29, 2020

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@GordonSmith
Copy link
Contributor Author

GordonSmith commented Dec 29, 2020

Added silent switch

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 29, 2020
@ghost
Copy link

ghost commented Dec 29, 2020

GordonSmith The package manager bot determined that the metadata was not compliant. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@sangam
Copy link
Contributor

sangam commented Dec 29, 2020

@GordonSmith - Multiple architectures in a single manifest file are not supported as of now.

Please refer to microsoft/winget-cli#132

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jan 4, 2021
@ghost ghost assigned KevinLaMS Jan 4, 2021
@ghost
Copy link

ghost commented Jan 4, 2021

This submission has moved to manual review.

@ghost ghost removed the Needs: Attention label Jan 4, 2021
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jan 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@GordonSmith
Copy link
Contributor Author

@sangam I removed the second architecture and added a "Silent" switch.

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jan 4, 2021
@ghost ghost assigned denelon Jan 4, 2021
@ghost
Copy link

ghost commented Jan 4, 2021

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jan 4, 2021
@ghost
Copy link

ghost commented Jan 4, 2021

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit eb2ac36 into microsoft:master Jan 4, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants