Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete 2.16.8.yaml #5587

Closed
wants to merge 1 commit into from
Closed

Delete 2.16.8.yaml #5587

wants to merge 1 commit into from

Conversation

DW-42
Copy link
Contributor

@DW-42 DW-42 commented Dec 18, 2020

This folder has been superseded by 'WinMerge-x64'

  • [✓] Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

This folder has been superseded by 'WinMerge-x64'
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Dec 18, 2020
@ghost ghost assigned KevinLaMS Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Dec 18, 2020
@KevinLaMS
Copy link
Contributor

Hey @DW-42. Looks like this manifest still works. Why do you want to remove it as well as 2.16.6?
Thanks.

@DW-42
Copy link
Contributor Author

DW-42 commented Dec 18, 2020

Hi @KevinLaMS , my end goal is to replace (rename) the "WinMerge" entry with "WinMerge-x64" to help clarify that it is the 64bit release of WinMerge. Does that make sense?
If I am going about this the wrong way, you will let me know - right?

@KevinLaMS
Copy link
Contributor

We have plans to support multiple architectures. microsoft/winget-cli#132
so a single manifest would be used for x86 and x64.

Once that is enabled, we would probably want to look at renaming them back. :( If you really want to change the name, I will approve the deletions when we have the replacements in the repo. I do not want to break people that may be depending on it.

@DW-42
Copy link
Contributor Author

DW-42 commented Dec 19, 2020

Understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants