-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with unicode characters in symlink target path #4834
Conversation
There are a few more places to be updated, where we directly create std::filesystem::path from SymlinkTarget |
when can we get a new preview to test this? |
We're getting ready to cut a release candidate for WinGet 1.9 and we'll start cutting WinGet 1.10 preview builds shortly after. ETA is early next week. |
@denelon the fix works fine in latest 1.9 stable versions, but I think the yt-dlp issue is similar. Can this be also fixed? All path strings in code should be checked for such unicode issues. |
If:
is resolved, then can you make a new issue calling out where you're seeing unicode so we can track that issue separately? That way we can close 161349. |
I found that there is already an old issue about unicode issues, so there is no need for creating a new one. |
@MagicAndre1981 thanks. I added it to the WinGet project to make sure we get that one fixed sooner rather than later. |
Resolves #3312
Fixes an issue when creating a symlink with a target path that includes unicode characters by converting the symlink target path to a UTF16 string prior to creation.
Added a test that includes unicode characters in the symlink target path and verified that install and uninstall are both supported.
Microsoft Reviewers: Open in CodeFlow