Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply loc update patch #3594

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Apply loc update patch #3594

merged 1 commit into from
Sep 5, 2023

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 5, 2023

Change

Apply localization update (reference 2308.31001)

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 5, 2023 16:50
@@ -95,6 +95,14 @@ Si desactiva esta directiva, no se pueden configurar fuentes adicionales para el
Si habilita esta configuración, los usuarios podrán instalar paquetes de sitios web que usen este protocolo.

Si deshabilita o no establece esta configuración, los usuarios no podrán instalar paquetes de sitios web que usen este protocolo.</string>
<string id="EnableWindowsPackageManagerCommandLineInterfaces">Habilitar Administrador de paquetes de Windows interfaces de línea de comandos</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't make much sense. It just says "Enable WPM CLI" but in Spanish that chain of nouns would need a connecting word to make sense, like "Enable CLI for WPM" or "Enable CLI of WPM".
But I don't think we have a way to add comments to the ADML, do we?

@@ -895,6 +903,9 @@ Se pueden configurar mediante el archivo de configuración "winget settings".</v
<data name="PolicyEnableWinGet" xml:space="preserve">
<value>Habilitar el Administrador de paquetes de Windows</value>
</data>
<data name="PolicyEnableWindowsPackageManagerCommandLineInterfaces" xml:space="preserve">
<value>Habilitar Administrador de paquetes de Windows interfaces de línea de comandos</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a comment here that this means "Enable CLI of/for WPM" so that it gets translated properly

<data name="InstallArchitectureArgumentDescription" xml:space="preserve">
<value>Seleccionar la arquitectura que se va a instalar</value>
<data name="ArchitectureArgumentDescription" xml:space="preserve">
<value>Selección de la arquitectura</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conjugation is changing from "do select" to "selection". Maybe we need to add a comment about how it is being used

</data>
<data name="IncludeUnknownArgumentDescription" xml:space="preserve">
<value>Actualizar paquetes aunque no se pueda determinar su versión actual</value>
</data>
<data name="IncludeUnknownInListArgumentDescription" xml:space="preserve">
<value>Enumere los paquetes incluso si no se puede determinar su versión actual. Solo se puede usar con el argumento --upgrade-available</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enumere" is imperative, as if it's giving an order. I'm not sure that is the right thing for a argument description. Maybe we should add a comment

@@ -1442,6 +1472,9 @@ Especifique uno de ellos con la opción --source para continuar.</value>
<data name="IncompatibleArgumentsProvided" xml:space="preserve">
<value>Argumentos de línea de comandos no compatibles proporcionados</value>
</data>
<data name="UpgradeArgumentDescription" xml:space="preserve">
<value>Enumere solo los paquetes que tienen una actualización disponible</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing about being imperative

<comment>{Locked="{0}"} {0} is a placeholder for the unrecognized error code.</comment>
</data>
<data name="ConfigurationUnitFailedConfigSet" xml:space="preserve">
<value>Error en la unidad de configuración debido a la configuración: {0}</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "error in the configuration unit due to the configuration: {0}". I have no idea what that is supposed to mean, but I'm guessing it didn't get translated properly

Comment on lines +1957 to +1962
<data name="InstallStubPackageDescription" xml:space="preserve">
<value>Instalación del paquete de código auxiliar para AppInstaller</value>
</data>
<data name="InstallFullPackageDescription" xml:space="preserve">
<value>Instalar el paquete completo para AppInstaller</value>
</data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a comment here, these two should start the same. Currently one says "do install" and the other says "installation"

<value>Instalar el paquete completo para AppInstaller</value>
</data>
<data name="ConfigurationEnableMessage" xml:space="preserve">
<value>Habilitar componentes de configuración. Requiere acceso al almacén.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Requires access to the storage". Was this supposed to be "the Microsoft Store"?

Comment on lines +1980 to +1983
<value>Deshabilite los componentes de configuración. Requiere acceso al almacén.</value>
</data>
<data name="ConfigurationDisablingMessage" xml:space="preserve">
<value>Deshabilitando componentes de configuración. Requiere acceso al almacén.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tense is not consistent with the enable one. It says "storage" instead of "MS Store". We need comments here

<value>Dependencias omitidas.</value>
</data>
<data name="FailedToRefreshPathWarning" xml:space="preserve">
<value>No se pudo actualizar PATH variable para el proceso. Las instalaciones posteriores que dependen de los cambios en la variable de PATH pueden generar errores.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason "PATH variable" got translated two different ways, one completely wrong. Not sure how that could be resolved with a comment..

@JohnMcPMS
Copy link
Member Author

I don't know if adding/changing comments re-raises the string in the localization team's system. But I think that at a minimum it would be good for you to create a PR with the comments here applied, and with any changes to the original strings that might help. I don't know the process for adding new terms though.

@JohnMcPMS JohnMcPMS merged commit 6559f65 into microsoft:master Sep 5, 2023
@JohnMcPMS JohnMcPMS deleted the apply-loc branch September 5, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants