Disable RTTI #3422
Merged
Disable RTTI #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
previously approved these changes
Jul 10, 2023
yao-msft
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Change
Disable RTTI (run-time type information) in almost all native projects. The only uses of it were in
IPackageandISourcedynamic casts, so explicit implementations were created for these to allow them to continue to function as before. Helper templates allow replacingdynamic_castwithPackageCastandstd::dynamic_pointer_castwithSourceCastdirectly.The file size dropped ~800 KB on ~5000 KB, which is about a 15% reduction in size.
Validation
Current tests should validate that we do not hit any new UB due to using a feature that should not work (although
std::dynamic_pointer_castactually fails to compile with RTTI disabled, so hopefully everything is covered in MS VC).Microsoft Reviewers: codeflow:open?pullrequest=#3422