Support for out of process configuration clients #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oting server lifetime
…ifetime management
…pper; is unhappy with WIL currently
…t to be manual activation only
…is enables scenarios where the resource information is not available from the repository to function.
…txt files to make tests happy
… that needs CppWinRT update
…implemented in tests
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msftrubengu
previously approved these changes
Jun 29, 2023
| isPackaged: false | ||
| filter: "TestCategory=InProcess" | ||
|
|
||
| - template: templates/e2e-test.template.yml | ||
| parameters: | ||
| title: "COM API E2E Tests (Out-of-process)" | ||
| title: "Microsoft.Management.Deployment E2E Tests (Out-of-process)" | ||
| isPackaged: true |
There was a problem hiding this comment.
You could add comtrace pipeline variable that is always false so enabling can be done without changing the code
| @@ -28,6 +29,21 @@ public class SetUpFixture | |||
| [OneTimeSetUp] | |||
| public void Setup() | |||
| { | |||
| if (TestContext.Parameters.Count == 0) | |||
| Factory(); | ||
| ~Factory(); | ||
|
|
||
| // Determines if the reference count is 0. |
There was a problem hiding this comment.
It is a boolean, you get to know both whether it is 0 AND whether it is not 0.
| auto serverUser = wil::get_token_information<TOKEN_USER>(); | ||
| IntegrityLevel serverIntegrityLevel = GetEffectiveIntegrityLevel(); | ||
|
|
||
| ImpersonateCOMorRPCCaller impersonation; |
There was a problem hiding this comment.
I got confused here... can you add a comment or name this var startImpersonation?
...osoft.Management.Configuration.Processor/Microsoft.Management.Configuration.Processor.csproj
Show resolved
Hide resolved
msftrubengu
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
The goal of this rather large change is to support out-of-process clients to configuration. This enables supported scenarios to not require shipping the entire PowerShell infrastructure, and instead leverage the one that is contained in our package.
The interface changes are breaking, but minimal. The goal is to remove the necessity for a processor to need the configuration module itself, while creating a single entry point that can be used for OOP cases (and many in-proc cases as well).
Validation
New tests are added for configuration via
winget.exe, and the existing configuration unit tests were updated to support running both in and out of process (where appropriate).Microsoft Reviewers: codeflow:open?pullrequest=#3363