Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM and ARM64 build configuration for powershell module #2744

Merged
merged 7 commits into from
Dec 7, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Dec 5, 2022

  • Adds ARM64 build configuration for UndockedRegFreeWinRT and Detours projects.
  • Modifies and cleans up build configurations in solution file.
  • Refactored CopyWinRTAct.dll post-build step that depends on the target platform value.

GUID reference for reviewer:
{463C0EF3-DF38-4C3D-8E7E-D4901E0CDC6C} = Microsoft.WinGet.Client.csproj
{31ED69A8-5310-45A9-953F-56C351D2C3E1} = UndockedRegFreeWinRT.vcxproj
{787EC629-C0FB-4BA9-9746-4A82CD06B73E} = Detours.vcxproj

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner December 5, 2022 23:26
@github-actions

This comment has been minimized.

@ryfu-msft ryfu-msft changed the title Add ARM64 build configuration for powershell module Add ARM and ARM64 build configuration for powershell module Dec 6, 2022
src/AppInstallerCLI.sln Outdated Show resolved Hide resolved
@yao-msft
Copy link
Contributor

yao-msft commented Dec 7, 2022

BinSkim found 2 issues:

D:\a\1\s\src\x64\Release\UndockedRegFreeWinRT\winrtact.dll: error BA2008: 'winrtact.dll' does not enable the control flow guard (CFG) mitigation. To resolve this issue, pass /guard:cf on both the compiler and linker command lines. Binaries also require the /DYNAMICBASE linker option in order to enable CFG.

D:\a\1\s\src\x64\Release\UndockedRegFreeWinRT\winrtact.dll: warning BA2024: 'winrtact.dll' was compiled with one or more modules that do not enable code generation mitigations for speculative execution side-channel attack (Spectre) vulnerabilities. Spectre attacks can compromise hardware-based isolation, allowing

@ryfu-msft ryfu-msft merged commit 33e936b into microsoft:master Dec 7, 2022
@ryfu-msft ryfu-msft deleted the cleanSolutionFiles branch December 7, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants