Repair-WinGetPackageManager does not handle missing Microsoft.UI.Xaml.2.7 or license #3374
Labels
Issue-Bug
It either shouldn't be doing this or needs an investigation.
PowerShell
Issue related to WinGet PowerShell Module or cmdlet
Milestone
Comments
msftrubengu
added a commit
that referenced
this issue
Jul 14, 2023
This PR address #3374 Change Make Repair-WinGetPackageManager repair known issues until its fixed or there's a non fixable state. Adds support for installing Microsoft.UI.Xaml.2.7 package from their GitHub release. Adds new parameter switch -AllUsers to Repair-WinGetPackageManager. If this is on, repair uses Add-AppxProvisionedPackage instead of Add-AppxPackage. Adds new integrity category to detect winget.exe failures due to missing license. To fix it Repair-WinGetPackageManager -AllUsers must be executed in admin mode. Fix adding preprocessor macros for net48. This cause Repair-WinGetPackageManager to always fail for Windows PowerShell. There's a breaking change in Repair-WinGetPackageManager. It will now throw if there's an issue repairing. Good thing this is a "prerelease" module 🗡️ Validation Test locally on machines where Microsoft.UI.Xaml.2.7 was not preinstalled and on Windows Server 2022.
|
Fixed by #3423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the missing feature / enhancement
While it will handle installing the VCLibs dependency, it will not install Microsoft.UI.Xaml.2.7. It will also not apply the license file.
I believe that the goal of
Repair-WinGetPackageManageris to have a functioning winget at the end, so it should handle these scenarios as well. The license will be automatically acquired if the machine is connected and capable, but that may not always be the case.Proposed technical implementation details
The current best option is to follow the steps in #1861 , but it may be worth prodding the Xaml owners again for a direct release path.
Some investigation will be required for the license installation. A quick check makes it seem like there is no direct, public API to add a license file. It may require also allowing for
Repair-WinGetPackageManager -AllUsersor similar so thatAdd-AppxProvisionedPackagecan be used which will take in the license file.The text was updated successfully, but these errors were encountered: