Revert "Change meaning of AddOrUpdate return bool (#4885)"

This reverts commit 3be2ba0.

src/AppInstallerCLITests/SQLiteIndex.cpp

@@ -3918,20 +3918,20 @@ TEST_CASE("SQLiteIndex_AddOrUpdateManifest", "[sqliteindex]")
     {
         SQLiteIndex index = SQLiteIndex::Open(tempFile, SQLiteStorageBase::OpenDisposition::ReadWrite);
 
-        // Update should return false
+        // Update with no updates should return false
         REQUIRE(!index.AddOrUpdateManifest(manifest, manifestPath));
 
         manifest.DefaultLocalization.Add<Localization::Description>("description2");
 
-        // Update should return false
+        // Update with no indexed updates should return false
         REQUIRE(!index.AddOrUpdateManifest(manifest, manifestPath));
 
-        // Update with indexed changes should still return false
+        // Update with indexed changes
         manifest.DefaultLocalization.Add<Localization::PackageName>("Test Name2");
         manifest.Moniker = "testmoniker2";
         manifest.DefaultLocalization.Add<Localization::Tags>({ "t1", "t2", "t3" });
         manifest.Installers[0].Commands = {};
 
-        REQUIRE(!index.AddOrUpdateManifest(manifest, manifestPath));
+        REQUIRE(index.AddOrUpdateManifest(manifest, manifestPath));
     }
 }

src/AppInstallerRepositoryCore/Microsoft/SQLiteIndex.cpp

@@ -194,8 +194,7 @@ namespace AppInstaller::Repository::Microsoft
 
         if (m_interface->GetManifestIdByManifest(m_dbconn, manifest))
         {
-            UpdateManifestInternalHoldingLock(manifest, relativePath);
-            return false;
+            return UpdateManifestInternalHoldingLock(manifest, relativePath);
         }
         else
         {

src/AppInstallerRepositoryCore/Microsoft/SQLiteIndex.h

@@ -95,15 +95,15 @@ namespace AppInstaller::Repository::Microsoft
         bool UpdateManifest(const Manifest::Manifest& manifest);
 
         // Adds or updates the manifest with matching { Id, Version, Channel } in the index.
-        // The return value indicates whether the manifest was added (true) or updated (false).
+        // The return value indicates whether the index was modified by the function.
         bool AddOrUpdateManifest(const std::filesystem::path& manifestPath, const std::filesystem::path& relativePath);
 
         // Updates the manifest with matching { Id, Version, Channel } in the index.
-        // The return value indicates whether the manifest was added (true) or updated (false).
+        // The return value indicates whether the index was modified by the function.
         bool AddOrUpdateManifest(const Manifest::Manifest& manifest, const std::filesystem::path& relativePath);
 
         // Updates the manifest with matching { Id, Version, Channel } in the index.
-        // The return value indicates whether the manifest was added (true) or updated (false).
+        // The return value indicates whether the index was modified by the function.
         bool AddOrUpdateManifest(const Manifest::Manifest& manifest);
 
         // Removes the manifest with matching { Id, Version, Channel } from the index.

src/WinGetUtil/WinGetUtil.h

@@ -159,7 +159,7 @@ extern "C"
         BOOL* indexModified);
 
     // Adds or Updates the manifest with matching { Id, Version, Channel } in the index.
-    // The return value indicates whether the manifest was added (true) or updated (false).
+    // The return value indicates whether the index was modified by the function.
     WINGET_UTIL_API WinGetSQLiteIndexAddOrUpdateManifest(
         WINGET_SQLITE_INDEX_HANDLE index,
         WINGET_STRING manifestPath,

src/WinGetUtilInterop.UnitTests/APIUnitTests/SQLiteIndexUnitTests.cs

@@ -188,13 +188,13 @@ public void AddOrUpdateManifest()
         {
             this.CreateIndexHelperForIndexTest((wrapper) =>
             {
-                // Add manifest; should return true.
+                // Add manifest.
                 string addManifest = Path.Combine(this.indexTestDataPath, PackageTest);
-                Assert.True(wrapper.AddOrUpdateManifest(addManifest, PackageTestRelativePath));
+                wrapper.AddOrUpdateManifest(addManifest, PackageTestRelativePath);
 
-                // Update manifest. name is different, should return false.
+                // Update manifest. name is different, should return true.
                 string updateManifest = Path.Combine(this.indexTestDataPath, PackageTestNewName);
-                Assert.False(wrapper.AddOrUpdateManifest(updateManifest, PackageTestRelativePath));
+                Assert.True(wrapper.AddOrUpdateManifest(updateManifest, PackageTestRelativePath));
 
                 return true;
             });

src/WinGetUtilInterop/Interfaces/IWinGetSQLiteIndex.cs

@@ -67,7 +67,7 @@ public interface IWinGetSQLiteIndex : IDisposable
         /// </summary>
         /// <param name="manifestPath">Path to manifest.</param>
         /// <param name="relativePath">Path of the manifest in the repository.</param>
-        /// <returns>True if added; false if updated.</returns>
+        /// <returns>True if index was modified.</returns>
         bool AddOrUpdateManifest(string manifestPath, string relativePath);
 
         /// <summary>