Identify the ProviderGuid failing with 1168 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Jul 12, 2023
| if (StringFromCLSID(providerId, &clsidString) != S_OK) | ||
| { | ||
| logWriter.TraceError( | ||
| Utility::FormatString(L"Failed to convert GUID to string").c_str() |
There was a problem hiding this comment.
This failure occurs because the GUID is not a valid one? Might be nice to provide some more context for the user.
There was a problem hiding this comment.
At this state in the program execution, we've done the check for valid GUID
From the docs for StringFromCLSID we can only get to this branch when the value returned is E_OUTOFMEMORY. We can therefore provide this detail instead of having a vague message that the conversion failed.
There was a problem hiding this comment.
@bobsira The Logic LGTM however add some description on the PR for context.
CharityKathure
previously approved these changes
Jul 13, 2023
iankingori
reviewed
Jul 13, 2023
iankingori
reviewed
Jul 13, 2023
iankingori
approved these changes
Jul 13, 2023
profnandaa
approved these changes
Jul 13, 2023
CharityKathure
pushed a commit
that referenced
this pull request
Dec 7, 2023
* identify the ProviderGuid failing with 1168 * added informative error messages * lint fixes * reverted the check for all failing providers * another lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change it to help us figure out ETW events failing with 1168: ERROR_NOT_FOUND code.
We do not have a fix at the moment.
This change is to do the following: