Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob pattern for binskim task #325

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

jlee671
Copy link
Contributor

@jlee671 jlee671 commented Dec 19, 2024

What

This PR includes two changes updating various yaml files

  1. Exclude test artifacts from binskim
  2. Delete installing specific .net sdk version, we can use what's on the pool

Why

  1. The test artifacts are being flagged to enable source link, which isn't necessary.
  2. No need to install specific version, use what's on the pool

How

Include glob pattern for which files to scan for binskim and delete installing .net sdk task

Testing

Manually ran ci pipeline and checked that vswhere.test.dll isn't being scanned unlike previously. Compliance pipeline also successfully ran.

@jlee671 jlee671 marked this pull request as draft December 19, 2024 00:46
@jlee671 jlee671 changed the title Update ci and compliance yaml failes Add glob pattern for binskim task Dec 19, 2024
@jlee671 jlee671 marked this pull request as ready for review December 19, 2024 20:09
@jlee671
Copy link
Contributor Author

jlee671 commented Dec 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jlee671 jlee671 merged commit 1dddd49 into main Dec 20, 2024
3 checks passed
@jlee671 jlee671 deleted the dev/jiwon/update-yaml-files branch December 20, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants