Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump .net sdk version #324

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Bump .net sdk version #324

merged 1 commit into from
Dec 14, 2024

Conversation

jlee671
Copy link
Contributor

@jlee671 jlee671 commented Dec 13, 2024

What

Bump .net sdk version

Why

nbgv is not compatiable with .net 6.0, causing ci pipeline failure

How

Bump .net sdk version in yaml

Test

[x] Ran test pipeline on this change

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if you could just drop the explicit version and install the latest. I'd assume that'd always work. In fact, the agents probably have it already and you don't need this step. Something to perhaps try. I can merge this for now since you can't, though, to get you unblocked.

@heaths
Copy link
Member

heaths commented Dec 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths heaths enabled auto-merge (squash) December 14, 2024 00:09
@heaths heaths merged commit 67ee1f5 into main Dec 14, 2024
3 checks passed
@heaths heaths deleted the dev/jiwon/fix-nbgv-issue branch December 14, 2024 00:16
@jlee671
Copy link
Contributor Author

jlee671 commented Dec 16, 2024

@heaths Thanks, I plan to make some changes in compliance yaml, so I will include the suggested changes in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants