Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source link and bump compiler and language standard version #323

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

jlee671
Copy link
Contributor

@jlee671 jlee671 commented Dec 11, 2024

What?

Enable source link and bump compiler version to v143 and language standard version to C++ 17 (to resolve source link path capital letters). Also deleted usage of deprecated functions or replaced the function.

Why?

Allow debugger to download underlying source files if needed

How?

Add source link package reference to config and vcxproj file

Testing?

  • Ran end-to-end testing and ensured the file was downloaded from sourcelink while debugging
    Screenshot 2024-12-10 141008

@jlee671 jlee671 requested a review from heaths December 11, 2024 19:26
@heaths
Copy link
Member

heaths commented Dec 11, 2024

@tydunkel what's wrong with the pipeline that it's not running? I remember there were some changes. The pipeline yaml here might be waiting on the wrong build.

@tydunkel
Copy link
Member

@tydunkel what's wrong with the pipeline that it's not running? I remember there were some changes. The pipeline yaml here might be waiting on the wrong build.

Permissions changed recently globally within DevDiv that blocks building by default now.

image

I'm not sure if I am a collaborator or not, but I'll try to trigger it

@tydunkel
Copy link
Member

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

update docker compose version

bump in test proj

temporary branch to test the cpp version bump
@jlee671
Copy link
Contributor Author

jlee671 commented Dec 12, 2024

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jlee671
Copy link
Contributor Author

jlee671 commented Dec 12, 2024

@heaths @tydunkel I'm not authorized to merge PR, could one of you guys merge it please?

@heaths heaths merged commit df18ab2 into main Dec 12, 2024
2 checks passed
@heaths heaths deleted the dev/jiwon/add-source-link-and-bump-compiler-version branch December 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants