Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CI pipeline to MicroBuild template #308

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

tydunkel
Copy link
Member

@tydunkel tydunkel commented Feb 8, 2024

To remain compliant, all production pipelines must be converted to the 1ES pipeline template. The MicroBuild template is an extension on that template that simplifies installation of MicroBuild plugins.

While doing this work, I updated to the 2022 VS pool. This required an additional update to the Dockerfile to use a 2022 image.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking. Everything looks fine. My only concern was whether VS property sheets would be broken by the changes to the .props and .vcxproj files, which I've experienced before with seemingly banal changes.

@heaths heaths merged commit f9116d2 into main Feb 13, 2024
3 checks passed
@heaths heaths deleted the dev/tydunkel/compliance/1es-pt branch February 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants