Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated a spelling mistake in user facing text. #307

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

0xNinshu
Copy link
Contributor

@0xNinshu 0xNinshu commented Dec 10, 2023

The spelling of lexicographically was incorrectly entered as lexigraphically. Made the minor adjustment rebuilt the project and ran the tests with no issue.

@0xNinshu
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Wow. I've been using this wrong forever, and I typically pride myself on using proper grammar even on the Internet. I learned something today!

That said, I don't know when the next release is planned. Perhaps @tydunkel can weigh in. Perhaps we can release a new version here under Releases at least.

@heaths heaths enabled auto-merge (squash) December 13, 2023 19:27
@0xNinshu
Copy link
Contributor Author

0xNinshu commented Jan 2, 2024

@heaths No problem, we are only human. :) I found the cli to be very useful all in all thanks for the hard work!
I did notice that it doesn't work with the build tools though. Maybe that is a feature? It would be nice to be able to detect installs of the stand alone build tools. If it does and I am mistaken let me know. Actually I didn't check if vswhere is shipped with the build tools.

@heaths
Copy link
Member

heaths commented Jan 2, 2024

I did notice that it doesn't work with the build tools though.

It does, but you have to pass -products * or reference the Build Tools ID specifically. See #8 for details why. tl;dr: originally, Build Tools contained very little support for workloads VS did, so it was not considered. Changing that now would be a breaking change because it's still a subset.

@heaths
Copy link
Member

heaths commented Jan 2, 2024

/azp run Microsoft.vswhere

@heaths
Copy link
Member

heaths commented Jan 2, 2024

@tydunkel the pipeline seems to be broken. I can't find it in Azure Pipelines where I thought it was defined. Did this get deleted late last year?

I'm tempted just to merge. This is a benign change...or at least should be. .rc file encodings can be finicky (IIRC, I think I converted this to UTF-8 a while ago at least, since it was UCS-2 previously and treated as binary by git), but I could pull and double check this locally, too.

@heaths heaths disabled auto-merge January 4, 2024 00:02
@heaths
Copy link
Member

heaths commented Jan 4, 2024

Verified locally. Not sure what's up with the pipelines - we'll investigate separately - but not holding up this PR any longer.

@heaths heaths merged commit 6ad44cd into microsoft:main Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants