-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Socket platform tests #647
Conversation
Remove SendHandshakeMessage - unused api.
@codito, |
|
||
namespace Microsoft.TestPlatform.CommunicationUtilities.PlatformTests | ||
{ | ||
public static class Program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for every test project that targets netcoreapp. We don't include NET.Test.Sdk directly.
More tests could be added as per these specification of TcpClient and TcpServer :
NoDelay : This field sounds interesting as it can significantly improve the efficiency of communication layer, specifically in remote scenarios.
|
@codito, |
We don't allow multiple client use. One SCM per ProxyExecutionManager.
This is a choice of the implementation. In our implementation we use the
This is internal implementation detail. Consumers of SocketCommunicationManager cannot change this. We use a length-prefixed buffer (BinaryReader/Writer), this shouldn't create a problem. Are you suggesting we add happy-path tests? NoDelay - is on our backlog for next PR (refactors SCM). |
@codito: Are these tests running in the PR today? |
Yes, they are running in the PR. |
Tests for SocketCommunicationManager functionality.