Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed telemetry data sharing exception #3676

Merged
merged 6 commits into from
May 27, 2022
Merged

Fixed telemetry data sharing exception #3676

merged 6 commits into from
May 27, 2022

Conversation

cvpoienaru
Copy link
Member

No description provided.

Evangelink
Evangelink reviewed May 25, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any test ensuring we won't regress on the cleaning of the metrics in both Initialize methods?

src/Microsoft.TestPlatform.CrossPlatEngine/Execution/ExecutionManager.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Shipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Shipped.txt Show resolved Hide resolved
src/testhost.x86/DefaultEngineInvoker.cs Outdated Show resolved Hide resolved
@cvpoienaru
Copy link
Member Author

Do we have any test ensuring we won't regress on the cleaning of the metrics in both Initialize methods?

Sorry, missed this comment. We don't have any such tests yet but I am working on adding them.

@cvpoienaru cvpoienaru enabled auto-merge (squash) May 26, 2022 08:13
@cvpoienaru cvpoienaru requested review from nohwnd and Evangelink May 26, 2022 16:57
@cvpoienaru cvpoienaru merged commit 7c9c533 into microsoft:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

@Evangelink Evangelink Awaiting requested review from Evangelink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvpoienaru @nohwnd @Evangelink