Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature flag logic to disable only semantics #3479

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Update feature flag logic to disable only semantics #3479

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea823b0
update feature flag logic to disable only semantics
MarcoRossignoli Mar 17, 2022
bfc6356
Update src/Microsoft.TestPlatform.CoreUtilities/FeatureFlag/DisableFe…
MarcoRossignoli Mar 17, 2022
4ab94e1
Update src/Microsoft.TestPlatform.CoreUtilities/FeatureFlag/DisableFe…
MarcoRossignoli Mar 17, 2022
9f2a032
address PR feedback
MarcoRossignoli Mar 17, 2022
ec7d410
rollback test name
MarcoRossignoli Mar 17, 2022
c61b0b5
address PR feedback
MarcoRossignoli Mar 17, 2022
2228b81
address PR feedback
MarcoRossignoli Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address PR feedback
  • Loading branch information
@MarcoRossignoli
MarcoRossignoli committed Mar 17, 2022
commit 2228b81761dbecfbf003dc3bd8aa9d7fe6e4ef96
4 changes: 2 additions & 2 deletions src/vstest.console/Internal/ConsoleLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,8 @@ private void TestRunCompleteHandler(object sender, TestRunCompleteEventArgs e)
{
// If ARTIFACTS_POSTPROCESSING is disabled
if (_featureFlag.IsDisabled(FeatureFlag.DISABLE_ARTIFACTS_POSTPROCESSING) ||
// DISABLE_ARTIFACTS_POSTPROCESSING_NEWSDKUX(new UX) is disabled
_featureFlag.IsDisabled(FeatureFlag.DISABLE_ARTIFACTS_POSTPROCESSING_NEWSDKUX) ||
// DISABLE_ARTIFACTS_POSTPROCESSING_NEW_SDK_UX(new UX) is disabled
_featureFlag.IsDisabled(FeatureFlag.DISABLE_ARTIFACTS_POSTPROCESSING_NEW_SDK_UX) ||
// TestSessionCorrelationId is null(we're not running through the dotnet SDK).
CommandLineOptions.Instance.TestSessionCorrelationId is null)
{
Expand Down