Do not show skip message always #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show skip message only when the IsTestProject is not defined
abhishkk
approved these changes
Dec 11, 2018
| @@ -52,7 +52,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| /> | |||
| </Target> | |||
|
|
|||
| <Target Name="ShowInfoMessageIfProjectHasNoIsTestProjectProperty" Condition="'$(IsTestProject)' != 'true'"> | |||
| <Target Name="ShowInfoMessageIfProjectHasNoIsTestProjectProperty" Condition="'$(IsTestProject)' == ''"> | |||
There was a problem hiding this comment.
If solution contains non-test dlls, then currently we are logging dll skip message as info. Ideally this message should be logged as verbose level.
If possible, can we make log level of skipping test dll message as verbose?
There was a problem hiding this comment.
There is no infra like that in place today.
There was a problem hiding this comment.
There is no infra like that in place today.
I beg to differ. VSTestLogsTask inherits from Task, which provides a logger. VSTestLogsTask can use that logger, with appropriate importance levels, instead of Console.WriteLine. Here's a PR: #1882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show skip message only when the IsTestProject is not defined
Fixes #1866