Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating log file for UWP via GUID #1387

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Creating log file for UWP via GUID #1387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.TestPlatform.PlatformAbstractions/uap10.0/Tracing/PlatformEqtTrace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ public void WriteLine(PlatformTraceLevel level, string message)
/// <inheritdoc/>
public bool InitializeVerboseTrace(string customLogFile)
{
LogFile = Path.GetTempPath() + Path.GetFileNameWithoutExtension(customLogFile).Replace(" ", "_") + ".TpTrace.log";
// Generate log file name using a GUID, as Path.GetFileNameWithoutExtension is throwing exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use string operation to get the name ?
This can be a fallback if the above fails, thoughts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for UWP team to come back & tell us why the API GetFileNameWithoutExtension is failing in local machine scenario.
I don't want to write any extra logic till we have to.

Let me know if there are any concerns.

LogFile = Path.GetTempPath() + Guid.NewGuid().ToString() + ".TpTrace.log";
TraceLevel = PlatformTraceLevel.Verbose;

return this.TraceInitialized();
Expand Down