Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data collector cleanup #1264

Merged
merged 12 commits into from
Nov 28, 2017
Merged

Data collector cleanup #1264

merged 12 commits into from
Nov 28, 2017

Conversation

harshjain2
Copy link
Contributor

@harshjain2 harshjain2 commented Nov 3, 2017 •
edited by codito
Loading

  1. Removed TargetDataCollectorUri as it is not required.
  2. Populated TestCaseStartEventArgs.DataCollectionContext.TestCase property. Earlier it was sent as null.

Fixes #1175

@harshjain2 harshjain2 requested a review from codito November 3, 2017 09:25
@harshjain2 harshjain2 requested a review from smadala November 13, 2017 08:06
@smadala smadala requested a review from singhsarab November 21, 2017 09:03
singhsarab
singhsarab reviewed Nov 21, 2017
View reviewed changes
src/Microsoft.TestPlatform.ObjectModel/DataCollector/Events/DataCollectionEventArgs.cs
Context = context;
TargetDataCollectorUri = targetDataCollectorUri;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep careful about this change, when you remove the property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshjain2 Searched for DataCollectors in devdiv using "TestPlatform.MSTest\ObjectModel\15.0\Microsoft.VisualStudio.TestPlatform.ObjectModel.dll" to compile, they do not seem to be using this property.

https://devdiv.visualstudio.com/DevDiv/_search?type=code&lp=search-Project&text=TestPlatform.MSTest%5CObjectModel%5C15.0&result=DefaultCollection%2FDevDiv%2FVS%2FGBlab%2Fvsumain%2F%2Fsrc%2Fvset%2FQTools%2FExecution%2FAgent%2FPlugins%2FMediaRecorder%2FMediaRecorderV2%2FMediaRecorderV2.csproj&preview=0&filters=ProjectFilters%7BDevDiv%7DRepositoryFilters%7BVS%7DBranchFilters%7Blab%2Fvsumain%7D&_a=search
Remove if from Code, & lets complete the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

singhsarab
singhsarab approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@singhsarab singhsarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with suggestion.

@harshjain2 harshjain2 merged commit 95f06ae into microsoft:master Nov 28, 2017
@harshjain2 harshjain2 mentioned this pull request Nov 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayankbansal018 mayankbansal018 mayankbansal018 left review comments

@smadala smadala smadala approved these changes

@singhsarab singhsarab singhsarab approved these changes

@codito codito Awaiting requested review from codito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshjain2 @smadala @singhsarab @mayankbansal018