Updated License URL for nuget packages. #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codito
approved these changes
Nov 3, 2017
smadala
reviewed
Nov 3, 2017
| @@ -8,7 +8,7 @@ | |||
| <owners>Microsoft</owners> | |||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | |||
| <description>The cross platform Microsoft Test Platform.</description> | |||
There was a problem hiding this comment.
Same description for both Microsoft.TestPlatform.Portable and Microsoft.TestPlatform?
There was a problem hiding this comment.
@pvlakshm Please suggest description for these packages.
| @@ -8,7 +8,7 @@ | |||
| <owners>Microsoft</owners> | |||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | |||
| <description>The cross platform Microsoft Test Platform.</description> | |||
| <licenseUrl>http://www.microsoft.com/web/webpi/eula/net_library_eula_enu.htm</licenseUrl> | |||
| <licenseUrl>https://www.visualstudio.com/microsoft-visual-studio-test-platform</licenseUrl> | |||
| <iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl> | |||
There was a problem hiding this comment.
Good to have tags element <tags>vstest visual-studio unittest testplatform mstest microsoft</tags>. Feel free to add more tags
|
Please add the EULA license link for the following packages Microsoft.TestPlatform & Microsoft.TestPlatform.Portable |
|
Please include Microsoft.TestPlatform.CLI as well. |
|
@dotnet-bot test this please. |
|
@dotnet-bot test Windows_NT / Release Build please. |
1 similar comment
|
@dotnet-bot test Windows_NT / Release Build please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated License URL for nuget packages.