Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Latest extensions from vsualm #1259

Merged
merged 12 commits into from
Nov 3, 2017
Merged

Get Latest extensions from vsualm #1259

merged 12 commits into from
Nov 3, 2017

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Nov 2, 2017

  • fixes for cpp folder name
  • Latest TMI adapter for NAR results fix

Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are picking from vsualm, & binaries are not signed there, please do make sure that in our external package, what all binaries we are bringing, are at least added in verify signing steps, & that we do verify we check if native dll's are signed as well

@smadala smadala changed the title Get Latest extension from vsualm Get Latest extensions from vsualm Nov 2, 2017
@harshjain2
Copy link
Contributor

@dotnet-bot test this please.

@codito
Copy link
Contributor

codito commented Nov 3, 2017

@smadala does this fix #1214?

@smadala
Copy link
Contributor Author

smadala commented Nov 3, 2017

@codito CPP directory path reduced 13 characters, this folder was blocking cloudbuild tpv2 packages to restore on dev machine and try out tpv2 with qtest on local dev machine.

@smadala smadala merged commit ab788a9 into master Nov 3, 2017
@smadala smadala deleted the cloud-build-private branch November 3, 2017 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants