Adding Acceptance Tests for Translation Layer #1254
Conversation
| return vsConsoleWrapper; | ||
| } | ||
|
|
||
| public string GetDefaultRunSettings() |
There was a problem hiding this comment.
Require docs for public APIs.
| public void RunSelectedTestsWithoutTestPlatformOptions() | ||
| { | ||
| var sources = new List<string> | ||
| { |
| @@ -22,7 +22,7 @@ public interface IVsTestConsoleWrapper | |||
| /// <summary> | |||
| /// Initialize the TestPlatform with Paths to extensions like adapters, loggers and any other extensions | |||
| /// </summary> | |||
| /// <param name="pathToAdditionalExtensions">Folder Paths to where extension DLLs are present</param> | |||
| /// <param name="pathToAdditionalExtensions">Full Paths to where extension DLLs are present</param> | |||
There was a problem hiding this comment.
This still can be mistaken for folder path, how about "Full paths to extension dlls"?
There was a problem hiding this comment.
Yes. Will change it.
| new TestPlatformOptions() { CollectMetrics = false }, | ||
| this.discoveryEventHandler2); | ||
|
|
||
| // Assert. |
There was a problem hiding this comment.
Assert for CollectMetrics=false?
| this.discoveryEventHandler); | ||
|
|
||
| // Assert. | ||
| Assert.AreEqual(6, this.discoveryEventHandler.DiscoveredTestCases.Count); |
There was a problem hiding this comment.
Add tests for parallel scenario.
There was a problem hiding this comment.
Not supported yet
| Assert.AreEqual(TestOutcome.Passed, this.runEventHandler.TestResults.FirstOrDefault().Outcome); | ||
|
|
||
| // Release builds optimize code, hence line numbers are different. | ||
| if (IntegrationTestEnvironment.BuildConfiguration.StartsWith("release", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Add source navigation test for discovery scenario too.
There was a problem hiding this comment.
Add navigation assert for other adapter too.
| } | ||
|
|
||
| [TestMethod] | ||
| public void DiscoverTestsUsingEventHandler2AndBatchSize() |
There was a problem hiding this comment.
Same as DiscoverTestsUsingDiscoveryEventHandler2AndTelemetryOptedOut?
There was a problem hiding this comment.
In both, RunSettings are different.
| { | ||
| this.testAssemblies = new List<string> | ||
| { | ||
| this.GetAssetFullPath("SimpleTestProject.dll"), |
There was a problem hiding this comment.
As we are running acceptance test only for net451 on CI, We miss the coverage for netcore.
| this.GetAssetFullPath("SimpleTestProject2.dll") | ||
| }; | ||
|
|
||
| this.vstestConsoleWrapper = this.GetVsTestConsoleWrapper(); |
There was a problem hiding this comment.
Is it good idea to create one vstestConsoleWrapper for entire session, to mimic test window?
There was a problem hiding this comment.
For maintainability, we are not doing this. In future, using Parallel may cause issues.
| @@ -61,6 +61,7 @@ public void CodedWebTestRunAllTests(RunnerInfo runnerInfo) | |||
|
|
|||
| [CustomDataTestMethod] | |||
| [NETFullTargetFramework(inIsolation: true, inProcess: true)] | |||
| [NETCORETargetFramework] | |||
| AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerInfo); | ||
| this.ExecuteNotSupportedRunnerFrameworkTests(runnerInfo.RunnerFramework, Netcoreapp, Message); | ||
|
|
||
| string runSettingsXml = @"<?xml version=""1.0"" encoding=""utf-8""?> |
| public void DiscoverTestsUsingDiscoveryEventHandler1(RunnerInfo runnerInfo) | ||
| { | ||
| AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerInfo); | ||
| this.ExecuteNotSupportedRunnerFrameworkTests(runnerInfo.RunnerFramework, Netcoreapp, Message); |
There was a problem hiding this comment.
Incase of not supported runner,skip the test.
| public void RunTestsWithFastFilter(RunnerInfo runnerInfo) | ||
| { | ||
| AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerInfo); | ||
| this.ExecuteNotSupportedRunnerFrameworkTests(runnerInfo.RunnerFramework, Netcoreapp, Message); |
There was a problem hiding this comment.
Nit: rename ExecuteNotSupportedRunnerFrameworkTests to IsSupportedRunner.
| this.vstestConsoleWrapper.RunTests( | ||
| sources, | ||
| this.GetDefaultRunSettings(), | ||
| new TestPlatformOptions() { TestCaseFilter = "FullyQualifiedName=NUnitTestProject.NUnitTest1.PassTestMethod1" }, |
| this.runEventHandler); | ||
|
|
||
| // Assert | ||
| Assert.AreEqual(1, this.runEventHandler.TestResults.Count); |
|
|
||
| var sources = new List<string> | ||
| { | ||
| this.testEnvironment.GetTestAsset("SimpleTestProject.dll", "netcoreapp1.0"), |
There was a problem hiding this comment.
Explicit targetframework not required.
| { | ||
| // On release, x64 builds, recursive calls may be replaced with loops (tail call optimization) | ||
| Assert.Inconclusive("On StackOverflowException testhost not exited in release configuration."); | ||
| return; |
Refer : #1239