Add fail fast on build failures of TestPlatform.sln #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smadala
commented
Oct 30, 2017
•
- Build should fail if there is error in build or publish steps.
- Build wasn't failing with latest dotnet-cli due to this, But it was failing in "test" step.
harshjain2
reviewed
Oct 30, 2017
scripts/build.ps1
Outdated
| @@ -190,6 +190,10 @@ function Invoke-Build | |||
| & $dotnetExe build $TPB_Solution --configuration $TPB_Configuration -v:minimal -p:Version=$TPB_Version -p:CIBuild=$TPB_CIBuild -p:LocalizedBuild=$TPB_LocalizedBuild | |||
| Write-Log ".. .. Build: Complete." | |||
|
|
|||
| if ($lastExitCode -ne 0) { | |||
There was a problem hiding this comment.
Can we move the logic to check to $lastExitCode to Set-ScriptFailed function?
harshjain2
approved these changes
Oct 30, 2017
codito
reviewed
Oct 31, 2017
scripts/build.ps1
Outdated
| @@ -604,8 +602,12 @@ function Get-ElapsedTime([System.Diagnostics.Stopwatch] $timer) | |||
| return $timer.Elapsed | |||
| } | |||
|
|
|||
| function Set-ScriptFailed | |||
| function Set-ScriptFailed-OnError | |||
There was a problem hiding this comment.
nit: function name doesn't match the Powershell naming convention.
codito
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.