Assembly Resolver perf improvement #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldnt be resolved. It is giving ~3.1 seconds perf improvement for 10k xunit tests from vstest.console during execution.
…pta/vstest into assemblyResolverPerfFix
navin22
approved these changes
Oct 26, 2017
smadala
reviewed
Oct 26, 2017
|
|
||
| return null; | ||
| this.resolvedAssemblies[args.Name] = null; |
There was a problem hiding this comment.
Add this at line:112, because there is exit path at 126 and we should operate on resolvedAssemblies inside lock (this.resolvedAssemblies) block.
There was a problem hiding this comment.
Its already under lock block. As per discussion, added this statement in one catch block.
smadala
reviewed
Oct 26, 2017
|
|
||
| return null; | ||
| this.resolvedAssemblies[args.Name] = null; |
There was a problem hiding this comment.
Add EqtTrace.IsInfoEnabled check for main flows.
…pta/vstest into assemblyResolverPerfFix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding null in resolvedAssemblies dictionary for assemblies which couldn't be resolved.
It is giving ~3.1 seconds perf improvement for 10k xunit tests from vstest.console during execution.