Fix to determine assembly PlatformTarget for AnyCpu assemblies #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshjain2
reviewed
Oct 18, 2017
| { | ||
| if (EqtTrace.IsVerboseEnabled) | ||
| { | ||
| EqtTrace.Verbose("AssemblyMetadataProvider:GetArchitecture() Failed get ProcessorArchitecture using AssemblyName API with exception: {0}", ex); |
There was a problem hiding this comment.
nit : AssemblyMetadataProvider.GetArchitecture() :
harshjain2
reviewed
Oct 18, 2017
| { | ||
| EqtTrace.Error("Failed to determine Assembly Architecture: {0}", ex); | ||
| EqtTrace.Info("Failed to determine Assembly Architecture with exception: {0}", e); |
There was a problem hiding this comment.
EqtTrace.IsVerboseEnabled?
harshjain2
approved these changes
Oct 23, 2017
codito
reviewed
Oct 24, 2017
|
|
||
| if (EqtTrace.IsVerboseEnabled) | ||
| { | ||
| EqtTrace.Verbose("AssemblyMetadataProvider.GetArchitecture() Failed get ProcessorArchitecture using AssemblyName API with exception: {0}", ex); |
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| namespace Microsoft.TestPlatform.PerformanceTests |
| Assert.IsTrue(stopWatch.ElapsedMilliseconds < expectedElapsedTime, string.Format(PerfAssertMessageFormat, expectedElapsedTime, stopWatch.ElapsedMilliseconds)); | ||
| } | ||
|
|
||
| private void TestDonetAssemblyArch(string projectName, string framework, Architecture expectedArch, long expectedElapsedTime) |
|
|
||
| private void LoadAssemblyIntoMemory(string assemblyPath) | ||
| { | ||
| // Load the file into RAM in ahead to avoid perf number(expectedElapsedTime) dependence on disk read time. |
There was a problem hiding this comment.
I am not sure if this hypothesis is true: any file read once as data will not be read again.
| @@ -73,6 +73,7 @@ public void InitializeShouldSetEnableCodeCoverageOfCommandLineOption() | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [Ignore("Issue with xml update after change framework to core2.0, ingore to run other tests on CI")] | |||
There was a problem hiding this comment.
Please remove it before merge. I'd suggest moving the framework to netcoreapp2.0 to be another PR.
There was a problem hiding this comment.
We are tracking P0 bug here, Harsh is working on fix.
| @@ -213,6 +213,7 @@ public void InitializeShouldAddDefaultSettingsIfNotPresent() | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [Ignore("Issue with xml update after change framework to core2.0, ingore to run other tests on CI")] | |||
There was a problem hiding this comment.
Please remove it before merge.
|
Got approve from @codito offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssemblyName.GetAssemblyNameto determine platform.