Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving discovery output to console logger #1111

Conversation

abhishekkumawat23
Copy link
Contributor

Moving logic of writing discovery output from ListTestsArgumentProcessor to console logger.

@Faizan2304
Copy link
Contributor

Faizan2304 commented Sep 19, 2017

After your change the output will change for run selected scenario.
Consider a scenario where test project has one test method with name TestMethod1
Run the following command vstest.console.exe TestProject1.dll --Tests:Test --logger:Console;Verbosity=normal

Old before your change

Starting test discovery, please wait...
Passed   Project1.UnitTest1.TestMethod1

Total tests: 1. Passed: 1. Failed: 0. Skipped: 0.
Test Run Successful.

Output after your change

Starting test discovery, please wait...
    TestMethod1
Passed   Project1.UnitTest1.TestMethod1

Total tests: 1. Passed: 1. Failed: 0. Skipped: 0.
Test Run Successful.

What is happening here

It is listing all the test which will meet the filter

Why it is happening

Run selected first call discovery and collect matching TestCases and then call Run on that selected test. Since we are now enabling ConsoleLogger for discovery as well and consoleLogger id listening for discovery events, its printing discovered tests on console.

@codito @singhsarab

@navin22
Copy link
Member

navin22 commented Sep 19, 2017

It will actually print all the discovery result and then the filtered tests list that ran. It's a special case needs to be handled, where both discovery and execution requests are made.

@smadala
Copy link
Contributor

smadala commented Sep 20, 2017

Please print number of tests discovered also.

@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
@singhsarab
Copy link
Contributor

@abhishkk Can we close this PR?

@abhishkk abhishkk closed this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants