Performance scripts fix. #1105
Merged
Performance scripts fix. #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
navin22
commented
Sep 18, 2017
- Adding TestAssets project to the TestPlatform.sln. So that it's restored and built.
- Fixing some bugs in perf.ps1 script. And adding it to the sln file.
- Added myget feeds of the adapters to the Nuget.config file.
- Adding TestAssets project to the TestPlatform.sln. So that it's restored and built. - Fixing some bugs in perf.ps1 script. And adding it to the sln file.
codito
reviewed
Sep 19, 2017
| @@ -167,7 +167,21 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DataCollectors", "DataColle | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.TestPlatform.Extensions.EventLogCollector.UnitTests", "test\DataCollectors\Microsoft.TestPlatform.Extensions.EventLogCollector.UnitTests\Microsoft.TestPlatform.Extensions.EventLogCollector.UnitTests.csproj", "{21DB138B-85B7-479E-91FE-01E0F972EC56}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EventLogUnitTestProject", "test\TestAssets\EventLogUnitTestProject\EventLogUnitTestProject.csproj", "{826CD5AF-44FA-40F6-B731-3980CADED8C0}" | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "EventLogUnitTestProject", "test\TestAssets\EventLogUnitTestProject\EventLogUnitTestProject.csproj", "{826CD5AF-44FA-40F6-B731-3980CADED8C0}" | |||
There was a problem hiding this comment.
Can we add these into a separate solution please? (only PerfTestProjects)
I started the work here: #1039, but it's not fully complete. Can give an idea though.
There was a problem hiding this comment.
I have added an Extra solution called TestAssets.sln & added most of the perf projects to it. Please take a look.
codito
reviewed
Sep 19, 2017
scripts/perf/perf.ps1
Outdated
| @@ -209,8 +209,8 @@ function Measure-DiscoveryTime($commandtorun, $payload) | |||
| { | |||
| Write-Log "Discovering Tests in $($payload.containerPath) using $($payload.currentRunner)" | |||
| $result = Get-TimeTaken $commandtorun | |||
| $result.Action = "Discovery" | |||
| $result.Goal = $payload.discoverygoal[$payload.runners.IndexOf($payload.currentRunner)] | |||
| $result.Action = "Discovery" | |||
There was a problem hiding this comment.
nit: please clean up the extra spaces
… TestPlatform.Sln tests will be less and opens fast in VS.
smadala
approved these changes
Sep 20, 2017
| @@ -2,7 +2,7 @@ | |||
| <!-- Package dependency versions --> | |||
| <Import Project="..\..\..\scripts\build\TestPlatform.Dependencies.props" /> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp1.1;net452</TargetFrameworks> | |||
| <TargetFrameworks>netcoreapp1.1;net451</TargetFrameworks> | |||
There was a problem hiding this comment.
Latest Xunit adapter supports net451?
There was a problem hiding this comment.
Good catch Sathya, No they don't. I have changed it. Thanks.
codito
approved these changes
Sep 20, 2017
|
@dotnet-bot test Windows_NT / Debug Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.