-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TunnelFactory web api #88200
TunnelFactory web api #88200
Conversation
import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; | ||
import { ILogService } from 'vs/platform/log/common/log'; | ||
|
||
export abstract class AbstractTunnelService implements ITunnelService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractTunnelService is mostly a copy of the original node TunnelService, with the exception of retainOrCreateTunnel, which is now abstract.
@@ -34,6 +34,26 @@ interface IExternalUriResolver { | |||
(uri: URI): Promise<URI>; | |||
} | |||
|
|||
interface TunnelOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TunnelOptions and Tunnel are copied from vscode.proposed.d.ts. ITunnelFactory is "inspired" by the tunnelFactory in vscode.proposed.d.ts.
import { Event, Emitter } from 'vs/base/common/event'; | ||
import { IDisposable } from 'vs/base/common/lifecycle'; | ||
|
||
export class NoOpTunnelService implements ITunnelService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by the TunnelService in workbench/service/remote/common/tunnelService.ts
Part of #81388