Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TunnelFactory web api #88200

Merged
merged 3 commits into from
Jan 9, 2020
Merged

TunnelFactory web api #88200

merged 3 commits into from
Jan 9, 2020

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 7, 2020

Part of #81388

import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
import { ILogService } from 'vs/platform/log/common/log';

export abstract class AbstractTunnelService implements ITunnelService {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractTunnelService is mostly a copy of the original node TunnelService, with the exception of retainOrCreateTunnel, which is now abstract.

@@ -34,6 +34,26 @@ interface IExternalUriResolver {
(uri: URI): Promise<URI>;
}

interface TunnelOptions {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TunnelOptions and Tunnel are copied from vscode.proposed.d.ts. ITunnelFactory is "inspired" by the tunnelFactory in vscode.proposed.d.ts.

import { Event, Emitter } from 'vs/base/common/event';
import { IDisposable } from 'vs/base/common/lifecycle';

export class NoOpTunnelService implements ITunnelService {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by the TunnelService in workbench/service/remote/common/tunnelService.ts

@alexr00 alexr00 self-assigned this Jan 7, 2020
@alexr00 alexr00 merged commit 978373f into master Jan 9, 2020
@alexr00 alexr00 deleted the alexr00/tunnelFactoryWebApi branch January 9, 2020 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant