-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet: guaranteed applying new preferences #8542
Conversation
By analyzing the blame information on this pull request, we identified @egamma and @alexandrudima to be potential reviewers |
Hi @mrmlnc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Ooops, 🔮 |
Hi @mrmlnc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Source: #8457
I found a problem with cancelling settings.
Steps to Reproduce:
Open VS Code
Add to settings:
Type
.test
and press tab to expand. Settings are applied. Result:<div CLASS="test"></div>
Delete added settings.
Type
.test
and press tab to expand, the setting doesn't apply. Result:<div CLASS="test"></div>
Why is it so simple?
The method
loadPreferences
only works with the documented values. Undocumented value not supported. An example of undocumented value:less.propertyEnd
— these values are hidden in Emmet. Because it is not needed for users.Why deleted condition to apply syntax profiles?
Here it is superfluous. Just got the keys and nothing more if the editor has no settings: