Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inactive tab foreground (#61106) #61187

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Inactive tab foreground (#61106) #61187

merged 1 commit into from
Oct 23, 2018

Conversation

infinnie
Copy link
Contributor

@infinnie infinnie commented Oct 18, 2018 •
edited by miguelsolorio
Loading

Fixes #61106.

@bpasero bpasero assigned miguelsolorio and unassigned bpasero Oct 22, 2018
miguelsolorio
miguelsolorio approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one!

@miguelsolorio miguelsolorio merged commit 29733d7 into microsoft:master Oct 23, 2018
@miguelsolorio miguelsolorio added this to the October 2018 milestone Oct 23, 2018
@miguelsolorio miguelsolorio added the themes Color theme issues label Oct 23, 2018
@infinnie infinnie deleted the inactive-tab-color branch October 24, 2018 01:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
themes Color theme issues
Projects
None yet
Milestone
October 2018
Development

Successfully merging this pull request may close these issues.

Default text color for non-current tabs in light themes does not pass the color contrast ratio check.
3 participants
@infinnie @miguelsolorio @bpasero